Conversation
can now read bz2 compressed psf files
Codecov Report
@@ Coverage Diff @@
## develop #2284 +/- ##
===========================================
+ Coverage 89.55% 89.64% +0.09%
===========================================
Files 156 172 +16
Lines 19410 21398 +1988
Branches 2785 2785
===========================================
+ Hits 17382 19183 +1801
- Misses 1432 1620 +188
+ Partials 596 595 -1
Continue to review full report at Codecov.
|
Member
Author
|
@MDAnalysis/coredevs this is good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2232
Changes made in this Pull Request:
self.filenamerather than the.nameattribute of the thing we open to workaround the bug with bz2filesI used a fixture to not have to add another file to the testsuite
PR Checklist