Add unwrap to radius_of_gyration#2305
Closed
NinadBhat wants to merge 1 commit intoMDAnalysis:developfrom
NinadBhat:test_rog
Closed
Add unwrap to radius_of_gyration#2305NinadBhat wants to merge 1 commit intoMDAnalysis:developfrom NinadBhat:test_rog
NinadBhat wants to merge 1 commit intoMDAnalysis:developfrom
NinadBhat:test_rog
Conversation
4 tasks
Contributor
Author
|
@orbeckst @richardjgowers can you kindly rerun the tests here? |
Member
|
@NinadBhat You can trigger a new CI test run yourself by simply closing and reopening the PR! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2305 +/- ##
===========================================
+ Coverage 89.63% 89.76% +0.12%
===========================================
Files 173 173
Lines 21498 21592 +94
Branches 2801 2832 +31
===========================================
+ Hits 19269 19381 +112
+ Misses 1628 1615 -13
+ Partials 601 596 -5 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@zemanj Thanks! |
Contributor
Author
|
@richardjgowers can you kindly review this? I have answered some of your questions at #2299. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1760
Changes made in this Pull Request:
PR Checklist