Skip to content

Unpin GSD from version 1.7.0#2321

Merged
richardjgowers merged 2 commits intoMDAnalysis:developfrom
IAlibay:GSDUnpin
Aug 9, 2019
Merged

Unpin GSD from version 1.7.0#2321
richardjgowers merged 2 commits intoMDAnalysis:developfrom
IAlibay:GSDUnpin

Conversation

@IAlibay
Copy link
Copy Markdown
Member

@IAlibay IAlibay commented Aug 8, 2019

Reverts #2320

Changes made in this Pull Request:

  • As per build 1.8.0 showing up for python 2.7 on conda glotzerlab/gsd#30 the py2.7 packages for GSD 1.8.0 have now been labelled as broken on conda-forge and shouldn't be picked up by travis-ci anymore.
  • I have therefore unpinned the version from 1.7.0.
  • However, since the max version for py2.7 is now 1.7.0, I haven't changed setup.py, I can revert that too if the consensus is that it isn't necessary.

PR Checklist

  • Tests? - Not needed
  • Docs? - Not needed
  • CHANGELOG updated? - Not needed
  • Issue raised/referenced?

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 8, 2019

Codecov Report

Merging #2321 into develop will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #2321     +/-   ##
==========================================
+ Coverage    89.64%   89.75%   +0.1%     
==========================================
  Files          157      173     +16     
  Lines        19547    21536   +1989     
  Branches      2804     2804             
==========================================
+ Hits         17523    19329   +1806     
- Misses        1431     1615    +184     
+ Partials       593      592      -1
Impacted Files Coverage Δ
core/util.py 100% <0%> (ø)
transformations/__init__.py 100% <0%> (ø)
auxiliary/base.py 89% <0%> (ø)
util.py 88.15% <0%> (ø)
topology/base.py 97.67% <0%> (ø)
__init__.py 91.89% <0%> (ø)
topology/__init__.py 100% <0%> (ø)
visualization/__init__.py 100% <0%> (ø)
coordinates/__init__.py 100% <0%> (ø)
datafiles.py 26.66% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e071ef4...5c0d166. Read the comment docs.

@orbeckst
Copy link
Copy Markdown
Member

orbeckst commented Aug 8, 2019

Can you try a clean git revert of the other commit (i.e. also revert setup.py) and see if the tests still pass? The less extra code the better.

Many thanks for following up with upstream!

@IAlibay
Copy link
Copy Markdown
Member Author

IAlibay commented Aug 9, 2019

Thanks, it should now all be reverted in 5c0d166 @orbeckst

@richardjgowers richardjgowers merged commit 7854011 into MDAnalysis:develop Aug 9, 2019
@IAlibay IAlibay deleted the GSDUnpin branch August 19, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants