Unpin GSD from version 1.7.0#2321
Merged
richardjgowers merged 2 commits intoMDAnalysis:developfrom Aug 9, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2321 +/- ##
==========================================
+ Coverage 89.64% 89.75% +0.1%
==========================================
Files 157 173 +16
Lines 19547 21536 +1989
Branches 2804 2804
==========================================
+ Hits 17523 19329 +1806
- Misses 1431 1615 +184
+ Partials 593 592 -1
Continue to review full report at Codecov.
|
Member
|
Can you try a clean Many thanks for following up with upstream! |
Member
Author
richardjgowers
approved these changes
Aug 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2320
Changes made in this Pull Request:
brokenon conda-forge and shouldn't be picked up by travis-ci anymore.However, since the max version for py2.7 is now 1.7.0, I haven't changed setup.py, I can revert that too if the consensus is that it isn't necessary.PR Checklist