Skip to content

Addresses pytest 5.1.0 failures#2330

Merged
richardjgowers merged 1 commit intoMDAnalysis:developfrom
IAlibay:Issue-2329
Aug 19, 2019
Merged

Addresses pytest 5.1.0 failures#2330
richardjgowers merged 1 commit intoMDAnalysis:developfrom
IAlibay:Issue-2329

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented Aug 18, 2019

Fixes #2329

Just creating this PR ahead of responses to #2329, if raising the pytest version is not desired at this point, I don't mind deleting the PR.

Changes made in this Pull Request:

  • Raised the minimum pytest version to 3.3.0 from 3.1.2.
  • Changed the match_expr keyword to match in pytest.warns which was causing issues with pytest 5.1.0 (see Tests failing with pytest 5.1.0 #2329 ).

PR Checklist

  • Tests? - Fixes existing test
  • Docs? - No docs associated as far as I am aware
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov
Copy link

codecov bot commented Aug 18, 2019

Codecov Report

Merging #2330 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2330      +/-   ##
===========================================
+ Coverage    89.82%   89.82%   +<.01%     
===========================================
  Files          173      173              
  Lines        21711    21711              
  Branches      2846     2846              
===========================================
+ Hits         19501    19502       +1     
  Misses        1615     1615              
+ Partials       595      594       -1
Impacted Files Coverage Δ
package/MDAnalysis/lib/transformations.py 78.62% <0%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e910a12...4218bea. Read the comment docs.

@richardjgowers
Copy link
Member

merging to get the CI train rolling again, 🚂 thanks @IAlibay

@richardjgowers richardjgowers merged commit 9b227a8 into MDAnalysis:develop Aug 19, 2019
@IAlibay IAlibay deleted the Issue-2329 branch August 19, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests failing with pytest 5.1.0

2 participants