Changes cell_angle units to degree (Issue #2327)#2339
Merged
richardjgowers merged 2 commits intoMDAnalysis:developfrom Sep 4, 2019
Merged
Changes cell_angle units to degree (Issue #2327)#2339richardjgowers merged 2 commits intoMDAnalysis:developfrom
richardjgowers merged 2 commits intoMDAnalysis:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2339 +/- ##
========================================
Coverage 89.89% 89.89%
========================================
Files 173 173
Lines 21784 21784
Branches 2861 2861
========================================
Hits 19583 19583
Misses 1609 1609
Partials 592 592
Continue to review full report at Codecov.
|
richardjgowers
requested changes
Sep 4, 2019
Member
richardjgowers
left a comment
richardjgowers
left a comment
There was a problem hiding this comment.
Looks good, couple comments
richardjgowers
approved these changes
Sep 4, 2019
Member
|
Cool, thanks @IAlibay , micro fixes are fine and easier to review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly fixes #2327
Apologies, this is very much a micro commit. Since I didn't manage to get this through before 0.20.0, I thought I might as well get it done asap so that the reader units deprecation makes more sense in 1.0.
A PR addressing the rest of #2327 is in progress, but considering how close we are to the start of term, it might get stalled for a few months.
Changes made in this Pull Request:
cell_anglevariable in the NetCDF writer todegreeinstead ofdegrees.PR Checklist