unreshape topologygroup attributes#2403
Merged
richardjgowers merged 2 commits intoMDAnalysis:developfrom Nov 18, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2403 +/- ##
========================================
Coverage 89.98% 89.98%
========================================
Files 176 176
Lines 22055 22055
Branches 2896 2896
========================================
Hits 19846 19846
Misses 1612 1612
Partials 597 597
Continue to review full report at Codecov.
|
orbeckst
approved these changes
Nov 16, 2019
Member
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
LGTM – as long as the tests pass.
lilyminium
force-pushed
the
unreshape-topologygroups
branch
from
0359ed6 to
7e3739a
Compare
richardjgowers
approved these changes
Nov 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2392
Changes made in this Pull Request:
PR Checklist