Skip to content

Removing multiprocessing portion of waterdynamics.hydrogenbondlifetimes#2520

Merged
orbeckst merged 6 commits intoMDAnalysis:developfrom
IAlibay:issue-2511
Feb 13, 2020
Merged

Removing multiprocessing portion of waterdynamics.hydrogenbondlifetimes#2520
orbeckst merged 6 commits intoMDAnalysis:developfrom
IAlibay:issue-2511

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented Feb 10, 2020

Fixes #2511

Changes made in this Pull Request:

  • Removes the multiprocessing portion of the Waterdynamics.HydrogenBondLifetimes code.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #2520 into develop will increase coverage by 0.1%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #2520     +/-   ##
==========================================
+ Coverage    90.46%   90.56%   +0.1%     
==========================================
  Files          170      170             
  Lines        22812    23106    +294     
  Branches      2976     2985      +9     
==========================================
+ Hits         20636    20927    +291     
- Misses        1580     1581      +1     
- Partials       596      598      +2
Impacted Files Coverage Δ
...DAnalysis/analysis/hydrogenbonds/hbond_analysis.py 95.45% <100%> (+0.08%) ⬆️
package/MDAnalysis/coordinates/PDB.py 89.88% <40%> (-0.76%) ⬇️
package/MDAnalysis/analysis/polymer.py 100% <0%> (ø) ⬆️
package/MDAnalysis/coordinates/NAMDBIN.py 100% <0%> (ø) ⬆️
package/MDAnalysis/core/topology.py 100% <0%> (ø) ⬆️
package/MDAnalysis/coordinates/MMTF.py 100% <0%> (ø) ⬆️
package/MDAnalysis/topology/PQRParser.py 98.93% <0%> (+0.01%) ⬆️
package/MDAnalysis/topology/LAMMPSParser.py 95.37% <0%> (+0.01%) ⬆️
package/MDAnalysis/analysis/waterdynamics.py 90.64% <0%> (+0.02%) ⬆️
package/MDAnalysis/coordinates/XDR.py 98.31% <0%> (+0.02%) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbd836f...b940f2a. Read the comment docs.

@IAlibay
Copy link
Member Author

IAlibay commented Feb 10, 2020

Seems like the MacOS build is failing somewhere on test_libdcd, this is reproducible across PRs (at least #2518 and #2516 are also failing at the same place).

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@orbeckst orbeckst self-assigned this Feb 13, 2020
@orbeckst orbeckst merged commit ea98a62 into MDAnalysis:develop Feb 13, 2020
@IAlibay IAlibay deleted the issue-2511 branch February 13, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Waterdynamics.HydrogenBondLifetimes nprocs > 1 appears to be broken

4 participants