Remove format from MemoryReader.timeseries#2567
Merged
orbeckst merged 3 commits intoMDAnalysis:developfrom Feb 29, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2567 +/- ##
========================================
Coverage 90.69% 90.69%
========================================
Files 170 170
Lines 22857 22857
Branches 2943 2943
========================================
Hits 20730 20730
Misses 1540 1540
Partials 587 587Continue to review full report at Codecov.
|
orbeckst
requested changes
Feb 29, 2020
Member
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
Looks good, only one comment on the docs. Thanks for doing all these important house-keeping PRs!
orbeckst
approved these changes
Feb 29, 2020
lilyminium
pushed a commit
to lilyminium/mdanalysis
that referenced
this pull request
Mar 4, 2020
* Completes MDAnalysis#1453 for MemoryReader (and towards v1.0 MDAnalysis#2443) * Removes support for the deprecated format keyword in MemoryReader.timeseries. * Removes deprecation test * Update CHANGELOG
fiona-naughton
added
maintainability
deprecation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards v1.0 #2443
Completes #1453 for MemoryReader
Changes made in this Pull Request:
formatkeyword in :meth:MemoryReader.timseries.PR Checklist