-
Notifications
You must be signed in to change notification settings - Fork 823
Start 2.0.0 #2729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Start 2.0.0 #2729
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1a8759c
finalised 1.0.0 changelog
richardjgowers 85ebe43
bumped version number to 1.0.0
richardjgowers 1a9e195
bumped version to 1.0.1
richardjgowers 9dba902
remove python 2.7 from travis CI
richardjgowers c9a17af
really increment the version this time
richardjgowers ec86541
Update .travis.yml
richardjgowers 583f6d0
derp I'm the best release manager
richardjgowers 35a9903
start v2.0 instead
richardjgowers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ env: | |
| - GIT_CI_EMAIL=TravisCI@mdanalysis.org | ||
| - MDA_DOCDIR=${TRAVIS_BUILD_DIR}/package/doc/html/html | ||
| # Set default python version to avoid repetition later | ||
| - PYTHON_VERSION=3.5 | ||
| - PYTHON_VERSION=3.6 | ||
| - BUILD_DOCS=false | ||
| - CODECOV=false | ||
| - PYTEST_FLAGS="--disable-pytest-warnings --durations=50" | ||
|
|
@@ -41,7 +41,6 @@ env: | |
| - CODECOV="true" SETUP_CMD="${PYTEST_FLAGS} --cov=MDAnalysis" | ||
| - PYTHON_VERSION=3.8 CODECOV="true" SETUP_CMD="${PYTEST_FLAGS} --cov=MDAnalysis" | ||
| - PYTHON_VERSION=3.7 CODECOV="true" SETUP_CMD="${PYTEST_FLAGS} --cov=MDAnalysis" | ||
| - PYTHON_VERSION=3.6 CODECOV="true" SETUP_CMD="${PYTEST_FLAGS} --cov=MDAnalysis" | ||
| - NUMPY_VERSION=1.13.3 | ||
| - NUMPY_VERSION=dev EVENT_TYPE="cron" | ||
|
|
||
|
|
@@ -65,13 +64,6 @@ matrix: | |
| CONDA_DEPENDENCIES="" | ||
| INSTALL_HOLE="false" | ||
|
|
||
| - env: NAME="python 2.7" | ||
| PYTHON_VERSION=2.7 | ||
| CODECOV="true" | ||
| NUMPY_VERSION=1.16 | ||
| SETUP_CMD="${PYTEST_FLAGS} --cov=MDAnalysis" | ||
| PIP_DEPENDENCIES="${PIP_DEPENDENCIES} setuptools<45.0.0" | ||
|
|
||
| - env: NAME="asv check" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note that ASV is currently running under 2.7 so we need an issue updating that to 3.x |
||
| PYTHON_VERSION=2.7 | ||
| CODECOV="false" | ||
|
|
@@ -85,14 +77,6 @@ matrix: | |
| env: PYTHON_VERSION=3.6 | ||
| NUMPY_VERSION=1.17.3 | ||
|
|
||
| # macOS Python 2.7 works in principle but times out on Travis CI: | ||
| # Disabled so that the tests can pass. | ||
| # - os: osx | ||
| # env: PYTHON_VERSION=2.7 | ||
| # NUMPY_VERSION=1.16 | ||
| # CODECOV="true" | ||
| # SETUP_CMD="${PYTEST_FLAGS} --cov=MDAnalysis" | ||
|
|
||
| - env: NAME='minimal' | ||
| PIP_DEPENDENCIES="" | ||
| CONDA_DEPENDENCIES=${CONDA_MIN_DEPENDENCIES} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't remember the exact issue but I think we said we would drop 3.5 too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was this one: #2541 (comment)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought dropping py2.7 and py3.5 would be a 2.0 thing, and that 1.xx releases would be just bug fixes, based on that same comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinging @orbeckst here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like everyone else is moving on, I'd like to just ditch python 2. If we find anything nasty that we fix I could do a backport/LTS thing, but I'd rather just force everyone to move to py 3, anaconda makes this possible enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was about to tag that comment! ;) I think this discussion is suited for the dev list, but if major packages are already dropping support for 3.5 (see #2541 (comment)) probably we should drop it too.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My view here (probably to be discussed on the dev list) is that it would be nice to increase the number of releases to include small bug fixes. The reason is that many issues are solved relatively quickly, but make it on master after a very long time (and therefore most users don't benefit from them).
For this reason, I think we should start dropping Python 2 and 3.5 support with 1.0.x releases (as done here) and tidy up the code as much as possible on the way to 2.0 (possibly with type hints, and other cool stuff).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In https://www.mdanalysis.org/2019/11/06/roadmap/ we said 1.x will be the last version of MDAnalysis that fully supports Python 2.7
This means that 1.x supports and tests 2.7 so we cannot remove Python 2.7 tests. Drop it for 2.0.
I'll start a discussion on the dev list instead of an issue thread...