Skip to content

Removes deprecated MDAnalysis.units.N_Avogadro#2737

Merged
richardjgowers merged 4 commits intoMDAnalysis:developfrom
IAlibay:deprecate-avogadro
Jun 11, 2020
Merged

Removes deprecated MDAnalysis.units.N_Avogadro#2737
richardjgowers merged 4 commits intoMDAnalysis:developfrom
IAlibay:deprecate-avogadro

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented Jun 10, 2020

Related to #2230 ?

Changes made in this Pull Request:

  • Removes MDAnalysis.units.N_Avogadro which was deprecated in 0.9

PR Checklist

  • Tests? N/A
  • Docs? N/A
  • CHANGELOG updated?
  • Issue raised/referenced? N/A?

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - less code is good!

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #2737 into develop will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2737      +/-   ##
===========================================
- Coverage    91.31%   91.31%   -0.01%     
===========================================
  Files          176      176              
  Lines        24019    24018       -1     
  Branches      3160     3160              
===========================================
- Hits         21932    21931       -1     
  Misses        1459     1459              
  Partials       628      628              
Impacted Files Coverage Δ
package/MDAnalysis/units.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a188e4...c75ee20. Read the comment docs.

@richardjgowers richardjgowers merged commit 3da643f into MDAnalysis:develop Jun 11, 2020
@fiona-naughton fiona-naughton added maintainability deprecation Deprecated functionality to give advance warning for API changes. labels Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecated functionality to give advance warning for API changes. maintainability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants