Removes deprecated density code#2740
Merged
orbeckst merged 16 commits intoMDAnalysis:developfrom Jun 13, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2740 +/- ##
===========================================
- Coverage 91.25% 91.19% -0.07%
===========================================
Files 176 176
Lines 23967 23798 -169
Branches 3153 3134 -19
===========================================
- Hits 21871 21702 -169
- Misses 1470 1474 +4
+ Partials 626 622 -4
Continue to review full report at Codecov.
|
5 tasks
This reverts commit a2bf4c4.
richardjgowers
approved these changes
Jun 12, 2020
Member
Author
|
In the interest of not having too many PRs dependent on other PRs, I've reverted I've also added a versionchanged to make it clear to anyone looking at the old density code is gone. |
orbeckst
approved these changes
Jun 13, 2020
Member
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
Looking good, minor comments/questions inline.
Member
|
On Jun 13, 2020, at 12:48 AM, Irfan Alibay ***@***.***> wrote:
I'm going to open a separate "remove py2 stuff from analysis methods" PR coming along at some point this morning, I'll remove it with that if that works for you?
Absolutely!
|
Member
|
Thanks for the work! |
PicoCentauri
pushed a commit
to PicoCentauri/mdanalysis
that referenced
this pull request
Mar 30, 2021
* removes deprecated density code (part of MDAnalysis#2739) * Removes density_from_Universe, density_from_PDB, Bfactor2RMSF, BfactorDensityCreator, and notwithin_coordinates_factory * Moves _set_user_grid to be a staticmethod of DensityAnalysis * Unused tests removed * Removal of six * some PEP8 string formatting changes * Adds a versionchanged for the removal * Adds changelog entry for deprecated density removal * Adds _set_user_grid to docs * Adds return entry
fiona-naughton
added
the
deprecation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #2739
Changes made in this Pull Request:
Todo:
PR Checklist