Skip to content

Fix rotateby documentation#2903

Merged
orbeckst merged 60 commits intoMDAnalysis:developfrom
RMeli:fix/docs
Aug 12, 2020
Merged

Fix rotateby documentation#2903
orbeckst merged 60 commits intoMDAnalysis:developfrom
RMeli:fix/docs

Conversation

@RMeli
Copy link
Member

@RMeli RMeli commented Aug 11, 2020

Fixes #2901

Changes made in this Pull Request:

  • Added call to rotateby (instead of rotate)
  • Removed () from atom group

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

RMeli and others added 30 commits August 7, 2019 18:41
RMeli added 23 commits April 10, 2020 09:47
@pep8speaks
Copy link

Hello @RMeli! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 43:80: E501 line too long (83 > 79 characters)
Line 45:80: E501 line too long (87 > 79 characters)
Line 51:80: E501 line too long (88 > 79 characters)
Line 62:80: E501 line too long (80 > 79 characters)
Line 74:80: E501 line too long (82 > 79 characters)
Line 154:1: W391 blank line at end of file

@RMeli RMeli changed the title Fix rotaeby documentation Fix rotateby documentation Aug 11, 2020
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@orbeckst orbeckst merged commit 5c0eb20 into MDAnalysis:develop Aug 12, 2020
lilyminium pushed a commit that referenced this pull request Jan 24, 2021
* Fixes #2901
* Changes made in this Pull Request:
    - Added call to rotateby (instead of rotate)
    - Removed () from atom group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Erroneous examples for rotateby

4 participants