Skip to content

Replace deprecated imp#2904

Merged
orbeckst merged 1 commit intoMDAnalysis:developfrom
yuxuanzhuang:imp_depr
Aug 12, 2020
Merged

Replace deprecated imp#2904
orbeckst merged 1 commit intoMDAnalysis:developfrom
yuxuanzhuang:imp_depr

Conversation

@yuxuanzhuang
Copy link
Copy Markdown
Contributor

Fixes #2897

Changes made in this Pull Request:

  • replace deprecated imp with types to mock chemfiles when building docs.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 12, 2020

Codecov Report

Merging #2904 into develop will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2904      +/-   ##
===========================================
- Coverage    92.89%   92.86%   -0.03%     
===========================================
  Files          187      187              
  Lines        24587    24587              
  Branches      3192     3192              
===========================================
- Hits         22840    22833       -7     
- Misses        1701     1708       +7     
  Partials        46       46              
Impacted Files Coverage Δ
package/MDAnalysis/coordinates/chemfiles.py 94.88% <100.00%> (ø)
package/MDAnalysis/due.py 66.66% <0.00%> (-8.34%) ⬇️
package/MDAnalysis/coordinates/base.py 94.64% <0.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9e749c...3893828. Read the comment docs.

@orbeckst orbeckst added the GSoC GSoC project label Aug 12, 2020
Copy link
Copy Markdown
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@orbeckst orbeckst self-assigned this Aug 12, 2020
@orbeckst orbeckst merged commit 3a31ef6 into MDAnalysis:develop Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

replace deprecated imp with importlib

3 participants