Skip to content

Update function signatures in core.Universe#2923

Merged
orbeckst merged 1 commit intoMDAnalysis:developfrom
lilyminium:fix-2921
Aug 28, 2020
Merged

Update function signatures in core.Universe#2923
orbeckst merged 1 commit intoMDAnalysis:developfrom
lilyminium:fix-2921

Conversation

@lilyminium
Copy link
Member

Fixes #2921

Changes made in this Pull Request:

  • update function arguments to named arguments instead of *args, **kwargs

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@pep8speaks
Copy link

pep8speaks commented Aug 27, 2020

Hello @lilyminium! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-08-27 17:29:46 UTC

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #2923 into develop will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2923      +/-   ##
===========================================
+ Coverage    92.96%   93.04%   +0.07%     
===========================================
  Files          187      187              
  Lines        24935    24995      +60     
  Branches      3258     3292      +34     
===========================================
+ Hits         23182    23256      +74     
+ Misses        1705     1691      -14     
  Partials        48       48              
Impacted Files Coverage Δ
package/MDAnalysis/core/universe.py 97.79% <100.00%> (+0.34%) ⬆️
util.py 89.47% <0.00%> (+0.01%) ⬆️
package/MDAnalysis/coordinates/base.py 95.12% <0.00%> (+0.48%) ⬆️
coordinates/base.py 95.12% <0.00%> (+0.49%) ⬆️
package/MDAnalysis/analysis/leaflet.py 99.15% <0.00%> (+2.81%) ⬆️
package/MDAnalysis/due.py 75.00% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e56e8...84d2275. Read the comment docs.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much cleaner! Thanks.

@orbeckst orbeckst self-assigned this Aug 28, 2020
@orbeckst orbeckst merged commit a8227f0 into MDAnalysis:develop Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Py3 TODO comments in core.Universe

4 participants