RDKitConverter bugfix on HIP residue#2941
Conversation
|
Hello @cbouy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-09-15 18:04:16 UTC |
Codecov Report
@@ Coverage Diff @@
## develop #2941 +/- ##
========================================
Coverage 93.02% 93.02%
========================================
Files 187 187
Lines 24962 24962
Branches 3261 3261
========================================
Hits 23220 23220
Misses 1694 1694
Partials 48 48
Continue to review full report at Codecov.
|
orbeckst
left a comment
There was a problem hiding this comment.
Can you add a comment to the tests for the new SMILES that they are related to this fix?
(I don't think that this requires a CHANGELOG entry as it is updating an unreleased feature.)
@IAlibay @fiona-naughton anything else that you see?
|
Thanks @cbouy – unless anyone else sees something obvious, anyone can merge it when convenient (just wait for CI). |
* fix hip with reaction
Currently HIP residues are likely to have a single double bond a a negatively charged carbon instead of 2 double bonds and a positive nitrogen
Changes made in this Pull Request:
PR Checklist