Update indexing in Charges and Masses get_residues#2991
Conversation
Fixes #2990 Avoid indexing a numpy array with a list of arrays, use a tuple of array instead. Multidimensional indexing of arrays with a non-tuple argument is deprecated.
|
Hello @jbarnoud! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-10-16 09:31:12 UTC |
Codecov Report
@@ Coverage Diff @@
## develop #2991 +/- ##
========================================
Coverage 93.05% 93.05%
========================================
Files 186 186
Lines 24609 24609
Branches 3187 3187
========================================
Hits 22900 22900
Misses 1661 1661
Partials 48 48
Continue to review full report at Codecov.
|
orbeckst
left a comment
There was a problem hiding this comment.
This seems non-controversial and easy to review: LGTM — and good idea to add the tests that now fail on the warning to avoid regression. We should follow the same pattern for future warning deprecation fixes (if we're not already doing it).
* Fixes MDAnalysis#2990 * Update indexing in Charges and Masses get_residues: Avoid indexing a numpy array with a list of arrays, use a tuple of array instead. Multidimensional indexing of arrays with a non-tuple argument is deprecated. * Turn warnings into errors to avoid regression over MDAnalysis#2990 * Update CHANGELOG
Fixes #2990
Avoid indexing a numpy array with a list of arrays, use a tuple of array
instead. Multidimensional indexing of arrays with a non-tuple argument
is deprecated.
PR Checklist
[ ] Docs?