Skip to content

Add dev and stable versions once#3009

Merged
orbeckst merged 3 commits intoMDAnalysis:developfrom
lilyminium:add-dev-once
Oct 24, 2020
Merged

Add dev and stable versions once#3009
orbeckst merged 3 commits intoMDAnalysis:developfrom
lilyminium:add-dev-once

Conversation

@lilyminium
Copy link
Member

Fixes #3006

Changes made in this Pull Request:

  • Fixed the for/else loop that accidentally added too many versions of dev/ and stable/

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

"url": os.path.join(URL, version),
"latest": False
})
else:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A rare for ... else ;-)

@orbeckst orbeckst self-assigned this Oct 24, 2020
@orbeckst orbeckst merged commit 2d14dbd into MDAnalysis:develop Oct 24, 2020
@orbeckst
Copy link
Member

I'll backport it for 1.0.1 #2768

orbeckst pushed a commit that referenced this pull request Oct 24, 2020
* fix #3006
* fixed the for/else loop that accidentally added too many versions of dev/ and stable/

(cherry picked from commit 2d14dbd)
@orbeckst orbeckst mentioned this pull request Oct 24, 2020
lilyminium added a commit to lilyminium/mdanalysis that referenced this pull request Dec 9, 2020
* fix MDAnalysis#3006
* fixed the for/else loop that accidentally added too many versions of dev/ and stable/

(cherry picked from commit 2d14dbd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs version selector has multiple repeated 'dev' entries

3 participants