Deploy docs via GitHub Actions CI#3053
Conversation
|
|
||
| - name: deploy_docs | ||
| if: github.event_name != 'pull_request' | ||
| env: |
There was a problem hiding this comment.
Moved deployment to within this file because it saved a lot of variable checking and possibly insecure token passing
Codecov Report
@@ Coverage Diff @@
## develop #3053 +/- ##
========================================
Coverage 93.09% 93.09%
========================================
Files 186 186
Lines 24665 24665
Branches 3196 3196
========================================
Hits 22961 22961
Misses 1656 1656
Partials 48 48 Continue to review full report at Codecov.
|
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
Nice, thank you!
Minor comments inline.
|
|
||
| run: | | ||
| # place the deploy call here | ||
| echo "Oh, maple syrup roast parsnips [Richard Gowers]" |
There was a problem hiding this comment.
Almost a shame to loose this citation ;-)
| BRANCH="${GITHUB_REF#refs/heads/}" | ||
|
|
||
| # the below turns off blocking as it causes large writes to stdout to fail | ||
| # (see https://github.com/travis-ci/travis-ci/issues/4704) |
There was a problem hiding this comment.
Thanks for the comment. Btw, I think what we're doing here we enabled blocking mode again, in case it was switched to non-blocking, at least that's how I read travis-ci/travis-ci#4704 (comment) and flags&~os.O_NONBLOCK.
Was this someone we only needed for Travis or is this a general problem, i.e., does gh-actions also have something weird running that switches to non-blocking mode?
There was a problem hiding this comment.
P.S.: Even if we don't strictly need it here anymore, I would only ever comment the line and not delete it, just in case we need it ever again.
There was a problem hiding this comment.
Thanks for pointing that out @orbeckst; you're right, gh-actions did not have this problem the 2 times I ran the deployment (where Travis was previously failing every time). I've commented it out and left a note.
lilyminium
force-pushed
the
gh-actions-docs
branch
from
1a95588 to
145f54a
Compare
3 negatives oh my
This reverts commit fc3e987.
lilyminium
force-pushed
the
gh-actions-docs
branch
from
145f54a to
d43c177
Compare
Fixes MDAnalysis#3046. Deploys docs in gh-ci.yaml script and removes Travis
Fixes MDAnalysis#3046. Deploys docs in gh-ci.yaml script and removes Travis
Fixes MDAnalysis#3046. Deploys docs in gh-ci.yaml script and removes Travis
4 participants
Fixes #3046
Changes made in this Pull Request:
Commits referencing my site / repo were to test the deployment of docs, as built here.
PR Checklist