Deprecate ParmedConverter taking Timestep objects#3172
Merged
IAlibay merged 8 commits intoMDAnalysis:masterfrom Apr 3, 2021
Merged
Deprecate ParmedConverter taking Timestep objects#3172IAlibay merged 8 commits intoMDAnalysis:masterfrom
IAlibay merged 8 commits intoMDAnalysis:masterfrom
Conversation
|
Hello @lilyminium! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-04-03 18:33:17 UTC |
Codecov Report
@@ Coverage Diff @@
## master #3172 +/- ##
==========================================
+ Coverage 90.96% 91.82% +0.86%
==========================================
Files 162 167 +5
Lines 22196 22702 +506
Branches 3201 3201
==========================================
+ Hits 20191 20847 +656
- Misses 1382 1771 +389
+ Partials 623 84 -539
Continue to review full report at Codecov.
|
IAlibay
reviewed
Mar 21, 2021
lilyminium
force-pushed
the
deprecate-parmed-ts
branch
from
5929a64 to
60e7268
Compare
lilyminium
force-pushed
the
deprecate-parmed-ts
branch
from
fc808d7 to
63fbaae
Compare
IAlibay
requested changes
Apr 3, 2021
Member
IAlibay
left a comment
IAlibay
left a comment
There was a problem hiding this comment.
Still gotta live that py2.7 life :(
IAlibay
approved these changes
Apr 3, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #Relates to #3031
Changes made in this Pull Request:
PR Checklist