Adding py3.9 to gh actions CI matrix#3245
Merged
orbeckst merged 2 commits intoMDAnalysis:developfrom Apr 27, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3245 +/- ##
===========================================
+ Coverage 92.81% 92.83% +0.01%
===========================================
Files 170 170
Lines 22811 22809 -2
Branches 3243 3242 -1
===========================================
+ Hits 21172 21174 +2
+ Misses 1591 1587 -4
Partials 48 48
Continue to review full report at Codecov.
|
Member
Author
|
3.9: 17375 passed, 165 skipped, 4 xfailed, 2 xpassed, 39633 warnings Looks like we're good. I'll add a macOS entry and I guess we now cover py3.9 fully. |
Member
Author
|
I'm not super into the idea that this has essentially ended up adding 2 extra entries to our CI matrix. But then I assume we will be able to drop 3.6 soon? |
orbeckst
approved these changes
Apr 27, 2021
Member
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
lgtm
Re: dropping 3.6 — we should make an official road map and come up with a policy. Different discussion.
lilyminium
pushed a commit
to lilyminium/mdanalysis
that referenced
this pull request
Apr 28, 2021
* Fixes MDAnalysis#2974 * Python 3.9 officially supported * Add Python 3.9 to testing matrix * Adds macOS CI entry, formalises 3.9 support
jbarnoud
added a commit
that referenced
this pull request
May 3, 2021
* added get_connections * modified tests for atoms.bonds/angles/dihedrals etc * modified parsers and things to use get_connections or bonds * updated CHANGELOG * pep8 * undo half of PR 3160 * add intra stuff * Update package/MDAnalysis/core/groups.py Co-authored-by: Jonathan Barnoud <jonathan@barnoud.net> * tighten up base class checking * update docstring * suppres warnings * Use absolute file paths in ITPParser (#3108) Fixes #3037 Co-authored-by: Lily Wang <31115101+lilyminium@users.noreply.github.com> * Adds aromaticity and Gasteiger charges guessers (#2926) Towards #2468 ## Work done in this PR * Add aromaticity and Gasteiger charges guessers which work via the RDKIT converter. * BLD: handle gcc on MacOS (#3234) Fixes #3109 ## Work done in this PR * gracefully handle the case where `gcc` toolchain in use on MacOS has been built from source using `clang` by `spack` (so it really is `gcc` in use, not `clang`) ## Notes * we could try to add regression testing, but a few problems: - `using_clang()` is inside `setup.py`, which probably can't be safely imported because it has unguarded statements/ code blocks that run right away - testing build issues is typically tricky with mocking, etc. (though in this case, probably just need to move `using_clang()` somewhere else and then test it against a variety of compiler metadata strings * Remove ParmEd Timestep writing "support" (#3240) Fixes #3031 * Adding py3.9 to gh actions CI matrix (#3245) * Fixes #2974 * Python 3.9 officially supported * Add Python 3.9 to testing matrix * Adds macOS CI entry, formalises 3.9 support * fix changelog * special metaclass * move function down * tidy code Co-authored-by: Jonathan Barnoud <jonathan@barnoud.net> Co-authored-by: Aditya Kamath <48089312+aditya-kamath@users.noreply.github.com> Co-authored-by: Cédric Bouysset <bouysset.cedric@gmail.com> Co-authored-by: Tyler Reddy <tyler.je.reddy@gmail.com> Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2974
A lot of our optional deps are now 3.9 compatible, let's see how well this goes / what fails.
Changes made in this Pull Request:
PR Checklist