Make contacts.Contacts use the Results class#3264
Merged
IAlibay merged 8 commits intoMDAnalysis:developfrom May 6, 2021
Merged
Make contacts.Contacts use the Results class#3264IAlibay merged 8 commits intoMDAnalysis:developfrom
IAlibay merged 8 commits intoMDAnalysis:developfrom
Conversation
20 tasks
Codecov Report
@@ Coverage Diff @@
## develop #3264 +/- ##
========================================
Coverage 93.02% 93.02%
========================================
Files 172 172
Lines 22698 22703 +5
Branches 3193 3193
========================================
+ Hits 21114 21119 +5
Misses 1534 1534
Partials 50 50
Continue to review full report at Codecov.
|
PicoCentauri
requested changes
May 6, 2021
Contributor
PicoCentauri
left a comment
PicoCentauri
left a comment
There was a problem hiding this comment.
That's music to my ears!
PicoCentauri
approved these changes
May 6, 2021
orbeckst
requested changes
May 6, 2021
Member
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
main change: deprecation entry in CHANGELOG
Comment on lines
+322
to
+328
| def test_warn_deprecated_attr(self, universe): | ||
| """Test for warning message emitted on using deprecated `timeseries` | ||
| attribute""" | ||
| CA1 = self._run_Contacts(universe, stop=1) | ||
| wmsg = "The `timeseries` attribute was deprecated in MDAnalysis" | ||
| with pytest.warns(DeprecationWarning, match=wmsg): | ||
| assert_equal(CA1.timeseries, CA1.results.timeseries) |
Member
There was a problem hiding this comment.
good test: check for message and equality
orbeckst
approved these changes
May 6, 2021
Member
|
I am approving & let you get on with it. Please merge when you're ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3261
Changes made in this Pull Request:
timeseriesin favour ofresults.timeseries.PR Checklist