Skip to content

Moves msd results to use the Results class#3265

Merged
IAlibay merged 6 commits intoMDAnalysis:developfrom
IAlibay:results-msd
May 6, 2021
Merged

Moves msd results to use the Results class#3265
IAlibay merged 6 commits intoMDAnalysis:developfrom
IAlibay:results-msd

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented May 6, 2021

Towards #3261

Changes made in this Pull Request:

  • Moves msd timeseries and msds_by_particle to use the Results class

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@IAlibay IAlibay requested a review from hmacdope May 6, 2021 15:52
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #3265 (1293005) into develop (503cf1e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3265   +/-   ##
========================================
  Coverage    93.02%   93.02%           
========================================
  Files          172      172           
  Lines        22704    22704           
  Branches      3193     3193           
========================================
  Hits         21121    21121           
  Misses        1533     1533           
  Partials        50       50           
Impacted Files Coverage Δ
package/MDAnalysis/analysis/msd.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 503cf1e...1293005. Read the comment docs.

@IAlibay IAlibay added this to the 2.0 milestone May 6, 2021
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IAlibay IAlibay merged commit b6ae72f into MDAnalysis:develop May 6, 2021
@IAlibay IAlibay deleted the results-msd branch May 6, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants