Move angles to results.angles for dihedral classes#3266
Move angles to results.angles for dihedral classes#3266IAlibay merged 5 commits intoMDAnalysis:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3266 +/- ##
========================================
Coverage 93.02% 93.03%
========================================
Files 172 172
Lines 22704 22714 +10
Branches 3193 3193
========================================
+ Hits 21121 21131 +10
Misses 1533 1533
Partials 50 50
Continue to review full report at Codecov.
|
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
minor doc thing — will add it directly & then approve
| .. attribute:: results.angles | ||
|
|
||
| Contains the time steps of the :math:`\phi` and :math:`\psi` angles for | ||
| each residue as an ``n_frames×n_residues×2`` :class:`numpy.ndarray` with | ||
| content ``[[[phi, psi], [residue 2], ...], [time step 2], ...]``. | ||
|
|
There was a problem hiding this comment.
There's a versionchanged that mentions it below (mainly bringing this up because I don't think I've been adding versionadded in the previous PRs), but we can start doing this if you want too (it's not exactly a lot of work).
There was a problem hiding this comment.
I know and that's (=changes) good. I find that the versionadded completes the picture. I put it in the general instructions in #3261 . We can update whenever, though.
| :inherited-members: | ||
|
|
||
| .. attribute:: angles | ||
| .. attribute:: results.angles |
- versionadded - small improvements about ref=True (based on user list question)
3 participants
Towards #3261
Changes made in this Pull Request:
anglestoresults.anglesfor Dihedral/Ramachandran/Janin classes.PR Checklist