Merged
Conversation
orbeckst
approved these changes
May 6, 2021
Comment on lines
+177
to
+178
| * `bat.BAT` now uses the `analysis.base.Results` class to store the `bat` | ||
| results attribute (Issue #3261, #3272) |
Member
There was a problem hiding this comment.
Technically not needed because bat wasn't released – but I think I said in the past "if it has an issue then list it"... so leave it in
Member
There was a problem hiding this comment.
I changed the issue text to include CHANGELOG entry
Codecov Report
@@ Coverage Diff @@
## develop #3273 +/- ##
========================================
Coverage 93.02% 93.02%
========================================
Files 172 172
Lines 22703 22704 +1
Branches 3193 3193
========================================
+ Hits 21119 21121 +2
+ Misses 1534 1533 -1
Partials 50 50
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3272
Towards #3261
Changes made in this Pull Request:
battoresults.bat.PR Checklist