Use Results in Hole2

[lilyminium]

Fixes #3269

Changes made in this Pull Request:

• Uses Results
• Tidies some code (e.g. self.frames is now part of AnalysisBase)

PR Checklist

• Tests?
• Docs?
• CHANGELOG updated?
• Issue raised/referenced?

[pep8speaks]

Hello @lilyminium! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file package/MDAnalysis/analysis/hole2/hole.py:

Line 563:70: W291 trailing whitespace

• In the file testsuite/MDAnalysisTests/analysis/test_hole2.py:

Line 270:80: E501 line too long (93 > 79 characters)

Comment last updated at 2021-05-08 00:43:00 UTC

[codecov]

Codecov Report

Merging #3292 (074645a) into develop (51fa4e4) will increase coverage by 0.01%.
The diff coverage is 82.85%.

@@             Coverage Diff             @@
##           develop    #3292      +/-   ##
===========================================
+ Coverage    93.04%   93.05%   +0.01%     
===========================================
  Files          172      172              
  Lines        22754    22761       +7     
  Branches      3192     3190       -2     
===========================================
+ Hits         21171    21181      +10     
+ Misses        1533     1530       -3     
  Partials        50       50              

Impacted Files	Coverage Δ
package/MDAnalysis/analysis/hole2/hole.py	74.47% <82.85%> (+1.28%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51fa4e4...074645a. Read the comment docs.

[PicoCentauri]

Just one minor doc addition.

[orbeckst]

only docs (what @PicoCentauri noted) and CHANGELOG

[orbeckst]

Waiting for CI... for CHANGELOG :-p.

(And depending on which other of the results PRs goes in, we're going to do it again... unless this one is first.)