Skip to content

[CI] Change concurrency group naming (Issue #3301)#3302

Merged
richardjgowers merged 3 commits intoMDAnalysis:developfrom
IAlibay:fix-3301
May 14, 2021
Merged

[CI] Change concurrency group naming (Issue #3301)#3302
richardjgowers merged 3 commits intoMDAnalysis:developfrom
IAlibay:fix-3301

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented May 14, 2021

Fixes #3301

Changes made in this Pull Request:

  • Changes the concurrency group to "${{ github.ref }}-${{ github.head_ref }}"
    This means that for commits to develop, the group will be set to refs/heads/develop, so any other CI jobs running from a commit will be cancelled and this will run instead.
    For a PR (let's say this one), the group will be named refs/pull/3302/merge-fix-3301, so it will only kill CI jobs within that PR with the same group name.

Note: I tried checking if an external group collision could happen, thankfully it looks like that's not possible.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@IAlibay IAlibay changed the title [CI] Change concurrency group naming (Issue 3301) [CI] Change concurrency group naming (Issue #3301) May 14, 2021
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #3302 (7ae50a6) into develop (80ce50d) will increase coverage by 3.98%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3302      +/-   ##
===========================================
+ Coverage    89.59%   93.58%   +3.98%     
===========================================
  Files          167      176       +9     
  Lines        21401    22883    +1482     
  Branches         0     3195    +3195     
===========================================
+ Hits         19175    21414    +2239     
+ Misses        2226     1418     -808     
- Partials         0       51      +51     
Impacted Files Coverage Δ
package/MDAnalysis/lib/formats/libmdaxdr.pyx 89.81% <0.00%> (ø)
package/MDAnalysis/lib/_cutil.pyx 100.00% <0.00%> (ø)
package/MDAnalysis/lib/c_distances.pyx 100.00% <0.00%> (ø)
package/MDAnalysis/lib/qcprot.pyx 100.00% <0.00%> (ø)
package/MDAnalysis/lib/nsgrid.pyx 91.30% <0.00%> (ø)
package/MDAnalysis/lib/_augment.pyx 100.00% <0.00%> (ø)
package/MDAnalysis/lib/formats/cython_util.pyx 100.00% <0.00%> (ø)
package/MDAnalysis/lib/c_distances_openmp.pyx 100.00% <0.00%> (ø)
package/MDAnalysis/lib/formats/libdcd.pyx 88.48% <0.00%> (ø)
package/MDAnalysis/coordinates/base.py 95.24% <0.00%> (+0.12%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80ce50d...7ae50a6. Read the comment docs.

@richardjgowers richardjgowers merged commit 122b884 into MDAnalysis:develop May 14, 2021
@IAlibay IAlibay deleted the fix-3301 branch May 14, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] github action triggered on commit is currently broken

2 participants