Skip to content

Remove unused dimensions lines in PQR reader#3378

Merged
richardjgowers merged 3 commits intodevelopfrom
issue-3327
Jul 31, 2021
Merged

Remove unused dimensions lines in PQR reader#3378
richardjgowers merged 3 commits intodevelopfrom
issue-3327

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented Jul 31, 2021

Fixes #3327

Changes made in this Pull Request:

  • Removes unused dimensions/unitcell lines
  • Adds note clarifying that dimensions are never set
  • Adds simple test

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated? - unecessary (not really a user facing change)
  • Issue raised/referenced?

@pep8speaks
Copy link

pep8speaks commented Jul 31, 2021

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-31 19:28:51 UTC

@IAlibay IAlibay added this to the 2.0 milestone Jul 31, 2021
@codecov
Copy link

codecov bot commented Jul 31, 2021

Codecov Report

Merging #3378 (2f5fb15) into develop (6531904) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3378   +/-   ##
========================================
  Coverage    93.62%   93.62%           
========================================
  Files          176      176           
  Lines        22839    22835    -4     
  Branches      3225     3224    -1     
========================================
- Hits         21382    21379    -3     
+ Misses        1406     1405    -1     
  Partials        51       51           
Impacted Files Coverage Δ
package/MDAnalysis/coordinates/PQR.py 95.23% <ø> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6531904...2f5fb15. Read the comment docs.

@richardjgowers richardjgowers merged commit 1e31180 into develop Jul 31, 2021
@IAlibay IAlibay deleted the issue-3327 branch May 29, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up use of unitcell in PQR

3 participants