Ensure that GRO reader treats lack of unit cells consistently#3380
Merged
Ensure that GRO reader treats lack of unit cells consistently#3380
Conversation
Member
Author
|
@lilyminium @mnmelo @jbarnoud I know you have many views on this, please do review. |
Codecov Report
@@ Coverage Diff @@
## develop #3380 +/- ##
===========================================
+ Coverage 93.62% 93.64% +0.02%
===========================================
Files 176 176
Lines 22839 22839
Branches 3225 3225
===========================================
+ Hits 21382 21387 +5
+ Misses 1406 1401 -5
Partials 51 51
Continue to review full report at Codecov.
|
lilyminium
requested changes
Aug 1, 2021
Member
lilyminium
left a comment
There was a problem hiding this comment.
My brain hasn't really woken up yet, but I found those negatives hard to parse. Maybe telling the user what boxes are allowed is easier?
Co-authored-by: Lily Wang <31115101+lilyminium@users.noreply.github.com>
lilyminium
approved these changes
Aug 13, 2021
Member
|
LGTM thank you @IAlibay, I'll let you decide if you want to wait on further reviews or merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3305
Changes made in this Pull Request:
PR Checklist