Skip to content

Adds missing timestep equality tests #3388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardjgowers merged 2 commits into from
Aug 16, 2021
Merged

Adds missing timestep equality tests #3388

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03ef1ed
Adds missing timestep equality tests
IAlibay Aug 16, 2021
9024167
Actually use parametrize
IAlibay Aug 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions testsuite/MDAnalysisTests/coordinates/test_timestep_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,13 @@ def test_wrong_pos_equality(self):
assert ts1 != ts2
assert ts2 != ts1

def test_no_pos_inequality(self):
ts1 = self.Timestep(self.size, positions=False)
ts2 = self.Timestep(self.size)

assert ts1 != ts2
assert ts2 != ts1

def test_check_vels_equality(self):
ts1 = self.Timestep(self.size, velocities=True)
ts2 = self.Timestep(self.size, velocities=True)
Expand Down Expand Up @@ -595,6 +602,16 @@ def test_check_wrong_forces_equality(self):
assert ts1 != ts2
assert ts2 != ts1

@pytest.mark.parametrize('dim1', [None, [2., 2., 2., 90., 90., 90.]])
def test_dims_mismatch_inequality(self, dim1):
ts1 = self.Timestep(self.size)
ts1.dimensions = dim1
ts2 = self.Timestep(self.size)
ts2.dimensions = [1., 1., 1., 90., 90., 90.]

assert ts1 != ts2
assert ts2 != ts1


# TODO: Merge this into generic Reader tests
# These tests are all included in BaseReaderTest
Expand Down