Conversation
- fix #3392 - writers are not required to process start, stop, step, which is what all our code does anyway - clarified that writer needs to ignore kwargs that they cannot process - clarified that __init__ can delay actual I/O until Write
- fix links to Trajectory API - link coordinates.ConverterBase to MDAnalysis.converters - minor reST fixes
Codecov Report
@@ Coverage Diff @@
## develop #3393 +/- ##
========================================
Coverage 93.69% 93.69%
========================================
Files 177 177
Lines 22959 22959
Branches 3234 3234
========================================
Hits 21511 21511
Misses 1397 1397
Partials 51 51
Continue to review full report at Codecov.
|
IAlibay
approved these changes
Aug 20, 2021
Member
Author
|
thanks, please merge whenever @IAlibay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3392
Changes made in this Pull Request:
PR Checklist