change error message numpy version 1.16 -> 1.18#3411
Conversation
|
Hello @IAlibay! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Codecov Report
@@ Coverage Diff @@
## develop #3411 +/- ##
========================================
Coverage 93.78% 93.78%
========================================
Files 177 177
Lines 23222 23222
Branches 3308 3308
========================================
Hits 21778 21778
Misses 1393 1393
Partials 51 51 Continue to review full report at Codecov.
|
tylerjereddy
left a comment
There was a problem hiding this comment.
That looks right--of course, for bleeding edge versions of Python or on some platforms that were only recently supported like ARM and Mac M1, we probably need even newer NumPy, but I suspect that can eventually be encoded in the pyproject.toml stuff.
|
I'll just put this in instead of suggesting that we use a variable to maintain that version in a single place (vs. error message, setup reqs and install reqs locations), since writing more shim code in Thanks! |
Fixes #3398 (comment)
Changes made in this Pull Request:
PR Checklist