Skip to content

change error message numpy version 1.16 -> 1.18#3411

Merged
tylerjereddy merged 1 commit intodevelopfrom
setup-numpy-1.18
Sep 1, 2021
Merged

change error message numpy version 1.16 -> 1.18#3411
tylerjereddy merged 1 commit intodevelopfrom
setup-numpy-1.18

Conversation

@IAlibay
Copy link
Copy Markdown
Member

@IAlibay IAlibay commented Sep 1, 2021

Fixes #3398 (comment)

Changes made in this Pull Request:

  • Change old error message numpy version

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@pep8speaks
Copy link
Copy Markdown

Hello @IAlibay! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 192:80: E501 line too long (83 > 79 characters)

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 1, 2021

Codecov Report

Merging #3411 (bae4d87) into develop (13265bc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3411   +/-   ##
========================================
  Coverage    93.78%   93.78%           
========================================
  Files          177      177           
  Lines        23222    23222           
  Branches      3308     3308           
========================================
  Hits         21778    21778           
  Misses        1393     1393           
  Partials        51       51           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13265bc...bae4d87. Read the comment docs.

@IAlibay IAlibay changed the title change error message numpy versino 1.16 -> 1.18 change error message numpy version 1.16 -> 1.18 Sep 1, 2021
Copy link
Copy Markdown
Member

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks right--of course, for bleeding edge versions of Python or on some platforms that were only recently supported like ARM and Mac M1, we probably need even newer NumPy, but I suspect that can eventually be encoded in the pyproject.toml stuff.

@tylerjereddy
Copy link
Copy Markdown
Member

I'll just put this in instead of suggesting that we use a variable to maintain that version in a single place (vs. error message, setup reqs and install reqs locations), since writing more shim code in setup.py probably isn't the best solution long-term anyway.

Thanks!

@tylerjereddy tylerjereddy merged commit 5c3fc1c into develop Sep 1, 2021
@tylerjereddy tylerjereddy deleted the setup-numpy-1.18 branch September 1, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants