Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3503 +/- ##
=========================================
Coverage 94.35% 94.35%
=========================================
Files 191 191
Lines 24985 24985
Branches 3375 3798 +423
=========================================
Hits 23575 23575
Misses 1362 1362
Partials 48 48 Continue to review full report at Codecov.
|
| */MDAnalysis/tests/* | ||
| */legacy/* | ||
| */due.py | ||
| concurrency = thread, multiprocessing |
There was a problem hiding this comment.
Since we use some multiprocessing in our code, we should include this I think (see: https://coverage.readthedocs.io/en/latest/config.html#run-concurrency)
There was a problem hiding this comment.
thanks for linking the docs, I agree
| PYTEST_FLAGS="--disable-pytest-warnings --durations=50" | ||
| if [ ${{ matrix.codecov }} = "true" ]; then | ||
| PYTEST_FLAGS="${PYTEST_FLAGS} --cov=MDAnalysis --cov-report=xml" | ||
| PYTEST_FLAGS="${PYTEST_FLAGS} --cov-config=.coveragerc --cov=MDAnalysis --cov-report=xml" |
There was a problem hiding this comment.
So it's not strictly necessary but we have multiple coveragerc files knocking about in the repo (I have another PR open looking to fix that) and I want to make 100% sure we're picking up the right thing.
There was a problem hiding this comment.
Better explicit than implicit.
(I was thinking even ./.coveragerc but that seems too much.)
|
This is a reasonable simple one that was giving us headaches with py37, but now that we ditched it, seems like CI is happy |
this will need a bit more thought I think |
| */MDAnalysis/tests/* | ||
| */legacy/* | ||
| */due.py | ||
| concurrency = thread, multiprocessing |
There was a problem hiding this comment.
thanks for linking the docs, I agree
| PYTEST_FLAGS="--disable-pytest-warnings --durations=50" | ||
| if [ ${{ matrix.codecov }} = "true" ]; then | ||
| PYTEST_FLAGS="${PYTEST_FLAGS} --cov=MDAnalysis --cov-report=xml" | ||
| PYTEST_FLAGS="${PYTEST_FLAGS} --cov-config=.coveragerc --cov=MDAnalysis --cov-report=xml" |
There was a problem hiding this comment.
Better explicit than implicit.
(I was thinking even ./.coveragerc but that seems too much.)
2 participants
Fixes #3372
Now that we've fixed sphinx issues, let's see if we can unhardcode CI dependencies - fixing this is a priority to allow folks downstream to properly build develop version of MDA.
Changes made in this Pull Request:
PR Checklist