Skip to content

BLD, MAINT: hoist packaging import #3527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IAlibay merged 1 commit into from
Mar 2, 2022
Merged

BLD, MAINT: hoist packaging import #3527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
from setuptools import setup, Extension, find_packages
from distutils.ccompiler import new_compiler
from distutils.sysconfig import customize_compiler
from packaging.version import Version
import codecs
import os
import sys
Expand Down Expand Up @@ -83,7 +84,6 @@
import Cython
from Cython.Build import cythonize
cython_found = True
from packaging.version import Version
Copy link
Copy Markdown
Member

@IAlibay IAlibay Feb 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So thinking about it a bit more, this explicitly makes packaging a core requirement for user builds right?

I guess the question is - where do we stand on eventually making Cython a core dependency (rather than us shipping the C/C++ files)? If we want to keep things the way we usually do, then I think we should possibly try/except around the packaging import and just set it to either say that either cython or packaging isn't found?

Copy link
Copy Markdown
Member Author

@tylerjereddy tylerjereddy Feb 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So thinking about it a bit more, this explicitly makes packaging a core requirement for user builds right?

What? I just moved the import so the error message would be better when packaging is absent--it was the MDA team who added this dependency months ago.


required_version = "0.16"
if not Version(Cython.__version__) >= Version(required_version):
Expand Down