Skip to content

Add packaging as a core dependency of MDAnalysis#3549

Merged
lilyminium merged 1 commit intodevelopfrom
packaging-dep
Mar 3, 2022
Merged

Add packaging as a core dependency of MDAnalysis#3549
lilyminium merged 1 commit intodevelopfrom
packaging-dep

Conversation

@IAlibay
Copy link
Copy Markdown
Member

@IAlibay IAlibay commented Mar 2, 2022

Follow-up from #3527

Changes made in this Pull Request:

  • Adds packaging as a core dep of MDAnalysis (this was added in Chemfiles updates #3499 but I messed up on adding it in properly sorry 😞 )

PR Checklist

  • Tests?
  • Docs? - userguide needs updating
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2022

Codecov Report

Merging #3549 (5c386d6) into develop (acd929f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3549   +/-   ##
========================================
  Coverage    94.11%   94.11%           
========================================
  Files          190      190           
  Lines        24642    24642           
  Branches      3309     3309           
========================================
  Hits         23192    23192           
  Misses        1404     1404           
  Partials        46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acd929f...5c386d6. Read the comment docs.

@IAlibay
Copy link
Copy Markdown
Member Author

IAlibay commented Mar 2, 2022

Lots of "TestOpenMMBasicSimulationReader" failures on MacOS, need to investigate in the morning.

Copy link
Copy Markdown
Member

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lilyminium lilyminium merged commit 4509856 into develop Mar 3, 2022
@lilyminium lilyminium deleted the packaging-dep branch March 3, 2022 13:41
@IAlibay
Copy link
Copy Markdown
Member Author

IAlibay commented Mar 3, 2022

Thanks @lilyminium - I'll fix CI in the next PR so we can be green prior to release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants