Enable automated wheel and dist uploads on releases#3680
Enable automated wheel and dist uploads on releases#3680richardjgowers merged 30 commits intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3680 +/- ##
========================================
Coverage 94.32% 94.33%
========================================
Files 191 191
Lines 24917 24917
Branches 3357 3357
========================================
+ Hits 23503 23505 +2
+ Misses 1365 1364 -1
+ Partials 49 48 -1
Continue to review full report at Codecov.
|
|
Ok this should be fine now, I've tested the testpypi portion of the release and wheels were built fine here: https://test.pypi.org/project/MDAnalysisTests/2.2.0.dev0/#modal-close @MDAnalysis/coredevs this needs reviewing as a priority, it's necessary for the 2.2.0 release. It should make our life a lot easier going forward too! @Seanny123 - I think this should fix the wheel issue, but if you can have a look at if this meets your needs that would be great. |
orbeckst
left a comment
There was a problem hiding this comment.
This is great DevOps work, @IAlibay . I have some minor questions because I am not that well versed in all the GH-actions magic and I am happy to positively re-review soon.
The main think I am looking for is minimal maintainer docs that explain the release process and outline the thinking behind the changes, i.e., in plain language, what are the goals and gotchas?
|
Ok, on top of updating the release notes in the wiki I've also opened up this PR in the userguide @orbeckst: MDAnalysis/UserGuide#208 I would prefer not have to duplicate docs a third time, so I might suggest that from now on all maintainer docs go in the userguide. |
This definitely meets my needs. Previously, I was also posting about trying to build the wheels with minimal Numpy versions, but I am no longer concerned about that, even if I can't tell from this PR the compatibility of the wheels being built. |
Awesome. Sorry it took so long to get done :( Our release methods are a bit overly complicated.
So it should be pulling from our pyproject.toml and using the minimum compatible versions of That being said, I agree that it's pretty annoying that it's not clear from the action what's going on. Let me try re-enabling it with a higher verbosity level, maybe that will tell us what it's doing. |
|
Ok yeah, it is respecting I'll leave verbosity at level 1 so we can debug better if something goes wrong :) |
|
I appreciate the increased verbosity. This will help me onboard other projects of this type (mdtraj in particular) to a CI release pipeline.
Your methods are perfectly understandable given the constraints! Making Python fast is non-trivial and makes packaging significantly harder. I'm actually super impressed you got it done at all, let alone so quickly! |
@MDAnalysis/coredevs I'm going to merge this in ~ 24h unless there are any further comments here. |
Fixes #1300
Changes made in this Pull Request:
TODO:
PR Checklist