Skip to content

Remove AMBER entry in extra_requires #3810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IAlibay merged 4 commits into from
Sep 4, 2022
Merged

Remove AMBER entry in extra_requires #3810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83a3185
Remove AMBER entry in extra_requires
IAlibay Aug 30, 2022
bf8b680
Merge branch 'develop' into extra-requires-removal
IAlibay Aug 31, 2022
f5bbb82
Merge branch 'develop' into extra-requires-removal
IAlibay Sep 4, 2022
19ca1f4
Update changelog
IAlibay Sep 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package/CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ Fixes
Enhancements

Changes
* The "AMBER" entry in setup.py's extra_requires has now been removed. Please
use `pip install ./package[extra_formats]` instead (PR #3810)

Deprecations

Expand Down
3 changes: 0 additions & 3 deletions package/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,9 +647,6 @@ def long_description(readme):
# you might prefer to use the version available through your
# packaging system
extras_require={
'AMBER': [ # REMOVE for 2.4.0, use 'extra_formats'
'netCDF4>=1.0', # for fast AMBER writing, also needs HDF5
],
'extra_formats': [ # additional file formats
'netCDF4>=1.0', # for fast AMBER writing, also needs HDF5
'h5py>=2.10', # H5MD
Expand Down