Skip to content

Add aarch64 testing via CirrusCI#4120

Merged
IAlibay merged 26 commits intodevelopfrom
cirrus-cron
Apr 12, 2023
Merged

Add aarch64 testing via CirrusCI#4120
IAlibay merged 26 commits intodevelopfrom
cirrus-cron

Conversation

@IAlibay
Copy link
Copy Markdown
Member

@IAlibay IAlibay commented Apr 8, 2023

Partly towards #4054

Changes made in this Pull Request:

  • osx-arm64 updates:
    • use pytest-xdist
    • switch over to ventura from monterey
    • reduced CI execution time from 9m to 3m
  • aarch64 linux testing
    • 8 core, 8 GB aarch64 runner using latest python docker build
  • start using starlark config for cirrus

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

📚 Documentation preview 📚: https://readthedocs-preview--4120.org.readthedocs.build/en/4120/

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ✅ Passed
testsuite ⚠️ Possible failure

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/4677222394/jobs/8284476513


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

@IAlibay
Copy link
Copy Markdown
Member Author

IAlibay commented Apr 8, 2023

9m to 3m for the cirrus osx-arm64 runner.. not bad

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (30baa14) 93.59% compared to head (a5f9faa) 93.59%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4120   +/-   ##
========================================
  Coverage    93.59%   93.59%           
========================================
  Files          192      192           
  Lines        25134    25134           
  Branches      4056     4056           
========================================
  Hits         23524    23524           
  Misses        1092     1092           
  Partials       518      518           

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@IAlibay
Copy link
Copy Markdown
Member Author

IAlibay commented Apr 8, 2023

How interesting, we can now reproduce #4112

@IAlibay IAlibay changed the title [WIP] Towards aarch64 cron testing via CirrusCI [WIP] Towards aarch64 testing via CirrusCI Apr 9, 2023
@IAlibay
Copy link
Copy Markdown
Member Author

IAlibay commented Apr 9, 2023

How interesting, we can now reproduce #4112

The issue is very much "because root", the question now is - how do we deal with this, either we detect root uuid in tests (flaky), or we just say "if you're running as a privileged user, don't".

@IAlibay IAlibay marked this pull request as ready for review April 9, 2023 06:15
@IAlibay
Copy link
Copy Markdown
Member Author

IAlibay commented Apr 9, 2023

Ok this should be good to review, will need this merged ahead of fully fixing #4054 for the v2.5.0 release.

@IAlibay
Copy link
Copy Markdown
Member Author

IAlibay commented Apr 9, 2023

CI issues seem to be related to pytest 7.3, not the changes added here (surprisly we touched the same tests at the same time, but it seems to be a coincidence). See: #4121

@IAlibay IAlibay changed the title [WIP] Towards aarch64 testing via CirrusCI Towards aarch64 testing via CirrusCI Apr 9, 2023
@IAlibay IAlibay changed the title Towards aarch64 testing via CirrusCI Add aarch64 testing via CirrusCI Apr 9, 2023
@IAlibay IAlibay added this to the 2.5.0 milestone Apr 9, 2023
@IAlibay
Copy link
Copy Markdown
Member Author

IAlibay commented Apr 11, 2023

@MDAnalysis/coredevs this needs to be the next priority review so that we can get #4054 done in time for the 2.5 release.

Copy link
Copy Markdown
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick but otherwise looks good, feel free to ignore.

.cirrus.star Outdated
@@ -0,0 +1,18 @@
# See https://cirrus-ci.org/guide/programming-tasks/ for more information on
# starlark CirrusCI files
# Inspired by scipy's .cirrus.star script
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link?

@IAlibay IAlibay merged commit 87821bb into develop Apr 12, 2023
@IAlibay IAlibay deleted the cirrus-cron branch April 12, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants