Conversation
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
|
9m to 3m for the cirrus osx-arm64 runner.. not bad |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #4120 +/- ##
========================================
Coverage 93.59% 93.59%
========================================
Files 192 192
Lines 25134 25134
Branches 4056 4056
========================================
Hits 23524 23524
Misses 1092 1092
Partials 518 518 see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
How interesting, we can now reproduce #4112 |
The issue is very much "because root", the question now is - how do we deal with this, either we detect root uuid in tests (flaky), or we just say "if you're running as a privileged user, don't". |
|
Ok this should be good to review, will need this merged ahead of fully fixing #4054 for the v2.5.0 release. |
|
CI issues seem to be related to pytest 7.3, not the changes added here (surprisly we touched the same tests at the same time, but it seems to be a coincidence). See: #4121 |
|
@MDAnalysis/coredevs this needs to be the next priority review so that we can get #4054 done in time for the 2.5 release. |
hmacdope
left a comment
There was a problem hiding this comment.
Nitpick but otherwise looks good, feel free to ignore.
.cirrus.star
Outdated
| @@ -0,0 +1,18 @@ | |||
| # See https://cirrus-ci.org/guide/programming-tasks/ for more information on | |||
| # starlark CirrusCI files | |||
| # Inspired by scipy's .cirrus.star script | |||
Partly towards #4054
Changes made in this Pull Request:
PR Checklist
📚 Documentation preview 📚: https://readthedocs-preview--4120.org.readthedocs.build/en/4120/