Skip to content

Fix permission errors w/ readonly tmpdirs and pytest 7.3#4122

Merged
IAlibay merged 4 commits intodevelopfrom
fix-permissionerr-pytest73
Apr 9, 2023
Merged

Fix permission errors w/ readonly tmpdirs and pytest 7.3#4122
IAlibay merged 4 commits intodevelopfrom
fix-permissionerr-pytest73

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented Apr 9, 2023

Azure pipelines has been failing recently (see #4121 ), due to the latest pytest 7.3 release.

The source of the error seems to be a mixture of windows, python 3.9, pytest and pathlib incompatibilities when trying to clean up temporary directories that have been set to read-only.

To fix this, here we just conclude the one affected test by re-enabling write permissions to the directory and removing it ahead of the test completing.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

📚 Documentation preview 📚: https://readthedocs-preview--4122.org.readthedocs.build/en/4122/

@github-actions
Copy link

github-actions bot commented Apr 9, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ✅ Passed
testsuite ⚠️ Possible failure

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/4652406475/jobs/8232597712


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (a440165) 93.58% compared to head (7bed9f4) 93.59%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4122      +/-   ##
===========================================
+ Coverage    93.58%   93.59%   +0.01%     
===========================================
  Files          192      192              
  Lines        25134    25134              
  Branches      4056     4056              
===========================================
+ Hits         23521    23524       +3     
+ Misses        1094     1092       -2     
+ Partials       519      518       -1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@IAlibay
Copy link
Member Author

IAlibay commented Apr 9, 2023

@MDAnalysis/coredevs this will need to take priority for merging so that we can get CI working again.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugly but ok, please see comment.

Happy Easter!

@IAlibay IAlibay merged commit 30baa14 into develop Apr 9, 2023
@IAlibay IAlibay deleted the fix-permissionerr-pytest73 branch April 9, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants