Skip to content

tests: modernize deprecated numpy assertions in test_gnm.py (ref #3743) #5175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shubhammittal2241 wants to merge 3 commits into from
Closed

tests: modernize deprecated numpy assertions in test_gnm.py (ref #3743) #5175

shubhammittal2241 wants to merge 3 commits into from
+3,040 −5,796

Conversation

@shubhammittal2241
Copy link

@shubhammittal2241 shubhammittal2241 commented Dec 9, 2025 •
edited by github-actions bot
Loading

This PR updates deprecated NumPy testing functions in test_gnm.py:

  • Replaces assert_almost_equal and assert_array_almost_equal with numpy.testing.assert_allclose
  • Uses pytest.approx for scalar floating point comparisons
  • Preserves existing tolerances and test behavior
  • All tests pass locally

Contributes to issue #3743.

Added myself to package/AUTHORS as a first-time contributor.

📚 Documentation preview 📚: https://mdanalysis--5175.org.readthedocs.build/en/5175/

@shubhammittal2241 shubhammittal2241 marked this pull request as draft December 10, 2025 04:33
@shubhammittal2241 shubhammittal2241 closed this by deleting the head repository Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shubhammittal2241