Add test to cover unit conversion path in DMSReader #5180
+7
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes : #3304
This PR adds a small test for
DMSReaderthat exercises the unit-conversion code path whenconvert_units=True.Details
convert_pos_from_nativeby triggering position accessTest verified locally with:
Notes
ts.dimensionsis intentionallyNonefor DMS files, so this test does not attempt to assert or modify box dimensions.📚 Documentation preview 📚: https://mdanalysis--5180.org.readthedocs.build/en/5180/