Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5240 +/- ##
===========================================
- Coverage 93.83% 93.83% -0.01%
===========================================
Files 180 180
Lines 22473 22476 +3
Branches 3189 3191 +2
===========================================
+ Hits 21088 21090 +2
Misses 923 923
- Partials 462 463 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BradyAJohnston
left a comment
There was a problem hiding this comment.
Probably good to also get someone more across the benchmarks than me - but this looks good.
orbeckst
left a comment
There was a problem hiding this comment.
Thanks. Sorry, I have not been good about updating the asv conf here, given that I really only ever interact with the one in https://github.com/MDAnalysis/benchmarks/tree/master/config , specifically the one for the production machine asv_c3potato.conf.json.
If ASV works for you with these minimal changes then I am happy to merge.
* Add python 3.14 * Add folders created by asv to gitignore
|
I didn't know that a separate repo existed for benchmarks. I came across ASV from this comment of PR #5226 and was trying it on |
Changes made in this Pull Request:
asvbenchmark runs are currently failing ondevelop.asv.conf.jsonstill references an unsupported Python version, which leads to the following error duringasv run:Fixing this leads to another error:
This PR updates the python version to 3.11 and adds an explicit
build_command(as seen in other projects likescipy) after whichasvruns fine.LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: no
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--5240.org.readthedocs.build/en/5240/