Merged
Conversation
- added @mimischi - sorted in chronological order (as in AUTHORS)
Member
Author
|
@mimischi can you please review and check that you're happy with this? @kain88-de @VOD555 @richardjgowers please check that you're happy with the author ordering. |
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 8 8
Lines 431 431
Branches 60 60
=======================================
Hits 417 417
Misses 8 8
Partials 6 6Continue to review full report at Codecov.
|
Member
|
I’m okay with the ordering
…On Thu 1. Nov 2018 at 22:16, codecov[bot] ***@***.***> wrote:
Codecov <https://codecov.io/gh/MDAnalysis/pmda/pull/77?src=pr&el=h1>
Report
Merging #77 <https://codecov.io/gh/MDAnalysis/pmda/pull/77?src=pr&el=desc>
into master
<https://codecov.io/gh/MDAnalysis/pmda/commit/aaa478ccc5095f92a8f1cac9edfa2b6b024da108?src=pr&el=desc>
will *not change* coverage.
The diff coverage is n/a.
[image: Impacted file tree graph]
<https://codecov.io/gh/MDAnalysis/pmda/pull/77?src=pr&el=tree>
@@ Coverage Diff @@## master #77 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 8 8
Lines 431 431
Branches 60 60
=======================================
Hits 417 417
Misses 8 8
Partials 6 6
------------------------------
Continue to review full report at Codecov
<https://codecov.io/gh/MDAnalysis/pmda/pull/77?src=pr&el=continue>.
*Legend* - Click here to learn more
<https://docs.codecov.io/docs/codecov-delta>
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov
<https://codecov.io/gh/MDAnalysis/pmda/pull/77?src=pr&el=footer>. Last
update aaa478c...d930726
<https://codecov.io/gh/MDAnalysis/pmda/pull/77?src=pr&el=lastupdated>.
Read the comment docs <https://docs.codecov.io/docs/pull-request-comments>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#77 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEGnVmbinn5d1Hzew6AbgGOtCmAs_fniks5uq2SSgaJpZM4YJO6O>
.
|
richardjgowers
approved these changes
Nov 1, 2018
Collaborator
|
It's good. |
Contributor
|
I'm also okay! |
Member
Author
|
Thanks all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: @mimischi was not added to AUTHORS and CHANGELOG (PR #64)
Changes made in this Pull Request:
PR Checklist