Run Windows on CI#64
Merged
Merged
Conversation
yutannihilation
commented
Jan 29, 2026
| run: cargo build --verbose --package app | ||
|
|
||
| - name: Clippy (lint) | ||
| if: runner.os == 'Linux' |
Member
Author
There was a problem hiding this comment.
It seems proj-sys's bundled feature doesn't work on Windows, so we need to skip here.
-- EMBED_RESOURCE_FILES=ON
-- Configuring incomplete, errors occurred!
--- stderr
feature flags specified source build
building libproj from source
disabling tiff support
CMake Error at CMakeLists.txt:211 (message):
sqlite3 binary not found!
CMake Warning at CMakeLists.txt:248 (message):
TIFF support is not enabled and will result in the inability to read some
grids
thread 'main' (2764) panicked at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\cmake-0.1.54\src\lib.rs:1119:5:
command did not execute successfully, got: exit code: 1
build script failed, must exit now
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 1.
nokonoko1203
approved these changes
Jan 30, 2026
Collaborator
nokonoko1203
left a comment
There was a problem hiding this comment.
great work!!!
lgtm!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #0
What I did
Notes
This pull request attempts to use vcpkg to install PROJ v9.6.2. While vcpkg feels a bit too heavy to solve the problem, but it seems this is the only reliable way.
For reference, these are the possible alternative path, but both requires windows-gnu target instead of windows-msvc. Now that windows-gnu is less maintained, I think we should use windows-msvc for now (I hope we can migrate to windows-gnullvm someday).