News endpoint was done, model, API and test were created#37
News endpoint was done, model, API and test were created#37davidfmb93 wants to merge 8 commits intomainfrom
Conversation
davidfmb93
requested review from
estebanl5,
mishyjari and
nathanfranz
as code owners
…d(PublishUtc,HashNextUrl). Furthermore, new tests and methods services have been created
|
|
||
| if(nextPage != null) { | ||
| queryParams.Add("cursor", nextPage); | ||
| }else { |
There was a problem hiding this comment.
Try to use CodeMaid to clean the code formatting, this should be in different lines
| /// <param name="limit">Limit the number of results returned, default is 10 and max is 1000</param> | ||
| /// <param name="sort">Sort field used for ordering</param> | ||
| /// <returns>NewsResponse</returns> | ||
| public async Task<NewsResponse> GetTodayNewsAsync( |
There was a problem hiding this comment.
This is not necesarry we can do it in the az func, only passing the current date as start and end.
There was a problem hiding this comment.
The function has been removed
Fixed it
| /// Get the next page of Polygon news. | ||
| /// </summary> | ||
| /// <param name="nextPage">hash of the next page</param> | ||
| public async Task<NewsResponse> GetNextPageNewsAsync(string nextPage = null){ |
There was a problem hiding this comment.
Don't know what do you need this?
There was a problem hiding this comment.
The function has been removed
Fixed it
| DateTime? endTime = default, | ||
| string ticker = null, | ||
| string order = null, | ||
| int? limit = null, |
There was a problem hiding this comment.
You can avoid the null here
You need to add nullable property to the csproj file
There was a problem hiding this comment.
I enable this property but need to initialize all variables to null.
| Task<PolygonResponse<TickerType>> GetTickerTypesAsync(string assetClass = default, string locale = default); | ||
|
|
||
| Task<NewsResponse> GetNewsAsync(DateTime? startTime = default, DateTime? endTime = default, string ticker = null, string order = null, int? limit = null, string sort = null); | ||
| Task<NewsResponse> GetNewsAsync( |
There was a problem hiding this comment.
My suggestion is to keep only one and remove the GetTodayNewsAsync and GetNextPageNewsAsync
There was a problem hiding this comment.
The function removed
Fixed it
|
Kudos, SonarCloud Quality Gate passed! |
3 participants
No description provided.