update cmake to use ctest and gtest properly#8
Merged
nathanhhughes merged 7 commits intomainfrom Aug 1, 2025
Merged
Conversation
Schmluk
approved these changes
Aug 1, 2025
Collaborator
Schmluk
left a comment
Schmluk
left a comment
There was a problem hiding this comment.
Looks great, many thanks!
- Minor point: I think this will require updating the badge name in the readme (for CI)
Collaborator
Author
Good catch (I forgot to do this when I updated the CI for Spark-DSG also)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not super urgent (trying to work through various packages so I can do
colcon testfor a workspace without a bunch of extraneousDartConfiguration.tcl not foundwarnings that hide actual test failures).Also updates the actions workflow to build against ros2 and native cmake