Rebuild javascript file structure#96
Merged
matt-bernhardt merged 4 commits into89-rebuild-apifrom Sep 9, 2016
Merged
Conversation
matt-bernhardt
changed the title
matt-bernhardt
force-pushed
the
matt/feature/restructure-js
branch
from
f37f5c7 to
ccebb10
Compare
matt-bernhardt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a more robust file structure to the theme's Javascript files:
There is now a build step for Javascript. Initially, this is simple uglification, with the results output into the
/js/build/directory. The mapping is is/tasks/options/uglify.jsThe main integration point for Javascript is
/js/mitlibnews.js(right now, this is only a name change for/js/myScripts.js). Everything else will get called from there.The LazyLoad jQuery library is now handled by NPM, and the uglify step takes that library and puts the result in
/js/build/In addition to running Uglify, the Grunt process now runs JShint and Jasmine. JShint is a linting service to look for syntax problems, while Jasmine is a unit testing framework. As of this PR, Jasmine conducts only the most basic test, but as the new module gets built out this will grow along with it.