Merged
Conversation
matt-bernhardt
force-pushed
the
uxws-1205-location-tweaks
branch
from
3ad6226 to
7374f22
Compare
** Why are these changes being introduced: * There are a few further changes needed to the "Location 2021" template which is launching on Monday. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/uxws-1205 ** How does this address that need: * Removes the old "Tab 1 Content Right" field (which gets loaded in the template as $content1) - which is unneeded on the new template. * Adds support for a newly-needed "featured-location" class, to group some rules which previously had been added using other classes. * Adds a maximum width to the right column for better readability. ** Document any side effects to this change: * The markup in the Hayden page will need to change to match these styles, but I am coordinating that.
matt-bernhardt
force-pushed
the
uxws-1205-location-tweaks
branch
from
7374f22 to
7d13b88
Compare
jazairi
approved these changes
Aug 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Use labels (
review needed,in progress, orpaused) to declare statusWhat does this PR do?
This makes a few updates to the new location template that was introduced in release 1.12.0. Specifically:
featured-location, to control how those content blocks behave on a few page widths.How can a reviewer manually see the effects of these changes?
This branch has been deployed to the staging site.
What are the relevant tickets?
Todo:
Requires new or updated plugins, themes, or libraries?
NO
Requires change to deploy process?
NO