Merged
Conversation
matt-bernhardt
force-pushed
the
uxws-template-updates
branch
from
2cb8b6e to
6338301
Compare
matt-bernhardt
force-pushed
the
uxws-template-updates
branch
from
2f97038 to
92575df
Compare
matt-bernhardt
force-pushed
the
uxws-template-updates
branch
from
92575df to
62ca53a
Compare
** Why are these changes being introduced: * Rather than adding a content-specific condition to the location template, hard-coding the Courtyard hours to the Hayden location page, this adds a sidebar to that area of the location template, with a default condition of the current content, allowing site builders to drop any number of widgets into the location header that will display hours information. * If accepted, this would be matched with a new release of our Pull Hours plugin, which would release a slim widget that would be placed in this sidebar for the Hayden page. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/uxws-1281 ** How does this address that need: * Adds a new Location Hours sidebar to the theme, with rendering of the sidebar added to the two location content templates (content-location and content-location-2021). The templates will continue to render their existing content for all location pages until a widget is added, making the transition seamless and requiring only two widgets be created. ** Document any side effects to this change: * The theme gets slightly more complex, with another sidebar added. The theme already has six sidebars defined, such as the front page hours area, the migrated content notice on the 404 template, and the search area of the home and search templates. * The designation of a location being available as a 24x7 study space is moved to the bottom of the "sidebar", just above the link to the hours grid. When there are no widgets in this sidebar, the display is unchanged, appearing after the location's hours information after a pipe. * Some improvements have been made in how this markup is handled. This includes treatment of boolean fields from the location record, and escaping the URL being output for the Study24 link.
matt-bernhardt
force-pushed
the
uxws-template-updates
branch
from
dcb9dc6 to
1b1c6db
Compare
jazairi
approved these changes
Oct 27, 2021
Contributor
jazairi
left a comment
jazairi
left a comment
There was a problem hiding this comment.
This looks good to me, and worth the slight increase in complexity I think. Nice work! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rolls up a number of requested changes to the theme. Details are in the linked tickets.
What does this PR do?
A few sentences describing the overall goals of the pull request's commits.
Why are we making these changes? Is there more work to be done to fully
achieve these goals?
Helpful background context (if appropriate)
How can a reviewer manually see the effects of these changes?
What are the relevant tickets?
Todo:
Requires new or updated plugins, themes, or libraries?
YES - this PR has been developed alongside an update to the MITlib Pull Hours plugin, which provides the widget that will be placed on the newly-added sidebar.
Requires change to deploy process?
NO