Update accounts link on mobile header#347
Merged
matt-bernhardt merged 1 commit intomainfrom Dec 21, 2021
Merged
Conversation
darcyduke
approved these changes
Dec 21, 2021
darcyduke
left a comment
darcyduke
left a comment
There was a problem hiding this comment.
This looks good to me, thank you Matt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This updates the link to the accounts page on the mobile header template, which was missed when we launched Alma originally.
Helpful background context (if appropriate)
This theme uses
header.phpto build both theheadelement of every page load, as well as to build the top elements of thebodyelement (The body tag itself, a skip link, the opening ofdiv.wrap-page, and theheaderelement.That header tag loads a number of other partials, including
inc/nav-mainfor the full width navigation, but also a separate partial for mobile navigation,inc/nav-smalldisplays.How can a reviewer manually see the effects of these changes?
This change has been deployed to the staging site.
What are the relevant tickets?
Todo:
Requires new or updated plugins, themes, or libraries?
NO
Requires change to deploy process?
NO