Draft
Conversation
Add Sass install step trying to Sass via JS rather than Ruby Define sass constant in Gruntfile Adding save-dev flag to npm install Explicit implementation of sass in task config Commenting out stylesheet tasks to confirm others work as expected Removes styles from default task Segmenting grunt tasks in actions step Undoes implementation in sass taskfile
matt-bernhardt
force-pushed
the
engx-117-github-actions
branch
from
889ad01 to
7c9f474
Compare
- "Prepare production release" now takes an action, and works on pushes to both main and this ticket's branch - The Grunt file has been slightly refactored to be (hopefully) cleaner. The local dev step is still `grunt build-local` - The debugging output in the "Build assets" workflow now includes an inspection of the stylesheet head. - Another release is created after the build_assets job, in addition to the release from development_release. I'm not sure where either exist in the git tree.
This includes some `git status` lines for debugging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Use labels (
review needed,in progress, orpaused) to declare statusWhat does this PR do?
A few sentences describing the overall goals of the pull request's commits.
Why are we making these changes? Is there more work to be done to fully
achieve these goals?
Helpful background context (if appropriate)
How can a reviewer manually see the effects of these changes?
What are the relevant tickets?
Screenshots (if appropriate)
Todo:
Requires new or updated plugins, themes, or libraries?
YES | NO
Requires change to deploy process?
YES | NO